-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In convit.py file, where does ConVit come from, really? #9
Comments
Hi, I was inspired by "Convolutional Self-Attention Networks" [2], and implemented the two-dimensional I will add the reference [2] to [2] Baosong Yang, Longyue Wang, Derek F Wong, Lidia S Chao, and Zhaopeng Tu. "Convolutional self-attention networks". NAACL, 2019. |
@xxxnell Uhm so what are the differences between these two attention mechanism? how-do-vits-work/models/attentions.py Lines 68 to 101 in 8752f4e
and how-do-vits-work/models/convit.py Lines 19 to 66 in 8752f4e
|
|
I think I understand now. Just one more question, if I use |
Yes. I'd really appreciate it if you would cite my paper. |
@xxxnell Quick question, which part of your publication mentioned |
@dinhanhx Oh! Sorry for the confusion. |
@xxxnell well I found that your |
@dinhanhx Ah, I think now I understand what you pointed out! I initially used two Convs for |
@xxxnell It was confusing to me since there are few similar convolution attention mechanism like yours. I did have a hard time trying to differentiate them. if I use AlterNet (theory), I cite your paper. Right? |
@dinhanhx Right. I think what you said is one of the best practices. |
Thanks for supporting me! |
Thanks for your comments on our "Convolutional SANs" (https://arxiv.org/abs/1904.03107). We are also very happy to see this can inspire your work. The paper on analyzing Vision Transformers is really insightful and interesting. |
We have implemented various SANs including "Convolutional SANs" at: |
Hi @longyuewangdcu , Thank you for the great paper and your kind words. And sorry I missed that implementation. I starred the repository, and I'll take a closer look! |
how-do-vits-work/models/convit.py
Lines 1 to 6 in 8752f4e
You said it's not the same with ConVit by d'Ascoli, Stéphane, et al. Then where does this ConVit come from? I ask because if I reuse this code, I want to know whom I should cite.
The text was updated successfully, but these errors were encountered: