Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change full screen to persist through navigation changes #108

Open
carlhemp opened this issue Dec 11, 2022 · 2 comments
Open

Change full screen to persist through navigation changes #108

carlhemp opened this issue Dec 11, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@carlhemp
Copy link
Contributor

carlhemp commented Dec 11, 2022 •
edited
Loading

Should stay full screen until changed by a click.

Revisit wakelock at the same time.
@carlhemp
Copy link
Contributor Author

Possibly also the left sidebar?

Consider ramifications to navigation experience... Hitting back button still intuitive?

@carlhemp
Copy link
Contributor Author

alternatively don't have it work through the URL, but have it enabled on the body or html element, and so not disabled until clicked upon - would require some thought for the urls/views that don't have a fullscreen currently - songbooks, and the songs list. Could have them show up as they currently do.

@carlhemp carlhemp changed the title Change full screen to work through the url Change full screen to persist through navigation changes Mar 23, 2023
@carlhemp carlhemp added the enhancement New feature or request label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carlhemp