Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor travis ci config and make it run tests under macOS as well #172

Closed

Conversation

webknjaz
Copy link

@webknjaz webknjaz commented Jun 16, 2018

I'm submitting this as a follow-up to #149 (comment) (encouraged by @ingydotnet)

Also fixes #200
Closes #212

@webknjaz
Copy link
Author

@ingydotnet I think you could ignore a few tests under a specific env and be fine with that.

@webknjaz
Copy link
Author

@ingydotnet could you please take a look at this matrix?

@webknjaz webknjaz force-pushed the feature/refactor-travis-ci-config branch from daec46a to ce14e72 Compare June 27, 2018 09:35
@webknjaz
Copy link
Author

webknjaz commented Jul 2, 2018

@ingydotnet ping?

@webknjaz webknjaz force-pushed the feature/refactor-travis-ci-config branch from c88cbed to 891daae Compare July 2, 2018 14:40
@ingydotnet
Copy link
Member

Hi @webknjaz

I'll look at this now. It seems to be failing travis though.

@webknjaz
Copy link
Author

webknjaz commented Jul 2, 2018

@ingydotnet yes, there are a few cases under OSX you mentioned earlier. I can ignore them until they're fixed. Fixing them myself is out of the scope of my intentions in this PR. I just want to help you with infra for testing. I've also added Python 3.7 stable job.

@webknjaz
Copy link
Author

webknjaz commented Jul 2, 2018

Oh.. there's more failures related to rebase on master. I'll fix them. Just do high-level review for now.

@ingydotnet
Copy link
Member

@webknjaz If you could patch pyyaml to skip the 5 OSX fails, that would be most appreciated.

Ping me when you get travis passing again.

Feel free to drop by #pyyaml IRC chatroom on irc.freenode.net if you want to chat to the devs in real time.

@webknjaz
Copy link
Author

webknjaz commented Jul 2, 2018

Sure, I'll ignore them and will clean up commits in the branch.

@webknjaz webknjaz force-pushed the feature/refactor-travis-ci-config branch 5 times, most recently from 65f7bfe to 0d43101 Compare July 2, 2018 22:47
@webknjaz
Copy link
Author

webknjaz commented Jul 2, 2018

@ingydotnet I guess it's ready now

@ingydotnet
Copy link
Member

@webknjaz cheers. having a look

@webknjaz
Copy link
Author

webknjaz commented Jul 2, 2018

@ingydotnet I recommend you canceling old PR builds because OS X jobs are really slow and throttled.
By the way, I can change the config in a way that they won't normally run but will run on cron builds (daily) or if triggered manually. This is quite useful if there's lots of incoming code changes simultaneously and you don't want to block processes with waiting for macOS.

@NyanKiyoshi
Copy link

NyanKiyoshi commented Jul 2, 2018

You think there is no real risk from breaking the travis build despite Xenial doesn't seem to be officially released by travis?

@ingydotnet
Copy link
Member

@webknjaz travis seems to be hanging on the Mac jobs.

@ingydotnet
Copy link
Member

@webknjaz just saw your "canceling old PR builds because OS X jobs" comment.

@webknjaz
Copy link
Author

webknjaz commented Jul 3, 2018

You think there is no real risk from breaking the travis build despite Xenial doesn't seem to be officially released by travis?

It must be OK. The only issue is that they attempt to access invalid url of there's no sudo. This way of enabling 3.7 has been suggested by Travis's employee. From my experience with Travis it will be fine.

hanging on the Mac jobs.

@ingydotnet
So do you agree to with running osx only on cron?

@webknjaz
Copy link
Author

webknjaz commented Jul 3, 2018

@ingydotnet I've decided not to wait and went ahead with limiting OS X jobs to manual, cron or tag triggers.

I've also noticed that https://github.com/yaml/pyyaml-build does not build proper manylinux1 wheels (PEP513), so if you want I'll submit a follow-up PR including building manylinux1 wheels for all platforms and completely automatic publish process from travis on tag.

Copy link
Member

@ingydotnet ingydotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have time to review everything yet.

.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@webknjaz
Copy link
Author

webknjaz commented Jul 6, 2018

@ingydotnet we can proceed now.

@webknjaz
Copy link
Author

webknjaz commented Jul 9, 2018

@ingydotnet ping

@webknjaz webknjaz force-pushed the feature/refactor-travis-ci-config branch from 89a902c to eb28242 Compare March 14, 2019 11:44
@webknjaz
Copy link
Author

Rebased. I've triggered macOS jobs in my fork as a demo: https://travis-ci.com/webknjaz/pyyaml/builds/104395740.

@webknjaz
Copy link
Author

@ingydotnet @perlpunk ^

@cclauss
Copy link
Contributor

cclauss commented Mar 14, 2019

Let’s drop Python 3.4 as it’s end of life is in two days.
https://devguide.python.org/#status-of-python-branches

@webknjaz
Copy link
Author

@cclauss fair enough... But again, it's not up to me to decide. If maintainers want it, we can remove those. At this stage I just want it to get merged finally...

@webknjaz
Copy link
Author

UPD: I've updated Python install method under macOS and now it's 2x faster. This also allows me to drop some entries from the allowed to fail list.

@webknjaz
Copy link
Author

webknjaz commented Mar 14, 2019

✔️ Build is green: https://travis-ci.org/yaml/pyyaml/builds/506258781

@nitzmahone
Copy link
Member

handled in #407

@nitzmahone nitzmahone closed this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.