-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor travis ci config and make it run tests under macOS as well #172
Conversation
@ingydotnet I think you could ignore a few tests under a specific env and be fine with that. |
f93ccbb
to
daec46a
Compare
@ingydotnet could you please take a look at this matrix? |
daec46a
to
ce14e72
Compare
@ingydotnet ping? |
c88cbed
to
891daae
Compare
Hi @webknjaz I'll look at this now. It seems to be failing travis though. |
@ingydotnet yes, there are a few cases under OSX you mentioned earlier. I can ignore them until they're fixed. Fixing them myself is out of the scope of my intentions in this PR. I just want to help you with infra for testing. I've also added Python 3.7 stable job. |
Oh.. there's more failures related to rebase on master. I'll fix them. Just do high-level review for now. |
@webknjaz If you could patch pyyaml to skip the 5 OSX fails, that would be most appreciated. Ping me when you get travis passing again. Feel free to drop by #pyyaml IRC chatroom on irc.freenode.net if you want to chat to the devs in real time. |
Sure, I'll ignore them and will clean up commits in the branch. |
65f7bfe
to
0d43101
Compare
@ingydotnet I guess it's ready now |
@webknjaz cheers. having a look |
@ingydotnet I recommend you canceling old PR builds because OS X jobs are really slow and throttled. |
You think there is no real risk from breaking the travis build despite Xenial doesn't seem to be officially released by travis? |
@webknjaz travis seems to be hanging on the Mac jobs. |
@webknjaz just saw your "canceling old PR builds because OS X jobs" comment. |
It must be OK. The only issue is that they attempt to access invalid url of there's no sudo. This way of enabling 3.7 has been suggested by Travis's employee. From my experience with Travis it will be fine.
@ingydotnet |
@ingydotnet I've decided not to wait and went ahead with limiting OS X jobs to manual, cron or tag triggers. I've also noticed that https://github.com/yaml/pyyaml-build does not build proper manylinux1 wheels (PEP513), so if you want I'll submit a follow-up PR including building manylinux1 wheels for all platforms and completely automatic publish process from travis on tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have time to review everything yet.
@ingydotnet we can proceed now. |
@ingydotnet ping |
89a902c
to
eb28242
Compare
Rebased. I've triggered macOS jobs in my fork as a demo: https://travis-ci.com/webknjaz/pyyaml/builds/104395740. |
Let’s drop Python 3.4 as it’s end of life is in two days. |
@cclauss fair enough... But again, it's not up to me to decide. If maintainers want it, we can remove those. At this stage I just want it to get merged finally... |
UPD: I've updated Python install method under macOS and now it's 2x faster. This also allows me to drop some entries from the allowed to fail list. |
✔️ Build is green: https://travis-ci.org/yaml/pyyaml/builds/506258781 |
handled in #407 |
I'm submitting this as a follow-up to #149 (comment) (encouraged by @ingydotnet)
Also fixes #200
Closes #212