-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making python 3.7 + compatible #212
Conversation
Python warning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works back to Python3.3, so LGTM
Should I absorb this commit into #172, which also enables testing against proper Python 3.7? |
Sure, sounds good to me. |
Done! |
Duplicate of #181 FWIW. |
@The-Compiler also absorbed into #172, which also enables testing. I hope it'll get reviewed and merged at some point |
LGTM! Is there a release planned? |
When is this PR expected to be merged and released? |
I would also like to know when this PR will be released |
@blazingkin In the next release. Hopefully in February. |
Also looking forward for this. The |
Can we please get this merged in? |
Is this still needed since #181 was merged already? |
You can close this one then |
Thanks! |
Python warning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working