Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] - Fix sorting props with numeric keys #2230

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

pawelnvk
Copy link

@pawelnvk pawelnvk commented Apr 9, 2019

Error occurs when some of props has keys declared as numbers. Object keys shouldn't be declared as numbers. Nevertheless, error should not occur.

Fixes #2212.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

lib/rules/sort-prop-types.js Outdated Show resolved Hide resolved
@ljharb ljharb added the bug label Apr 9, 2019
@ljharb ljharb force-pushed the sorting-numeric-props branch from a860541 to b37a504 Compare April 9, 2019 20:30
@ljharb ljharb merged commit b37a504 into jsx-eslint:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants