Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI ignoring .accessibilityrc #39

Open
ronilaukkarinen opened this issue Jan 29, 2018 · 2 comments
Open

CLI ignoring .accessibilityrc #39

ronilaukkarinen opened this issue Jan 29, 2018 · 2 comments

Comments

@ronilaukkarinen
Copy link

It seems command is ignoring .accessibilityrc, doesn't matter if it's in the same dir or at $HOME. Also tried the tip defined here, but doesn't really "solve" this issue. Also, getting TypeError: accessSniff.start is not a function with that script.

➜  air (master) sniff http://airdev.test -r txt
Starting Accessibility tests 

Testing http://airdev.test 

Testing http://airdev.test failed
JsDom Cannot render urls, please set the browser option to true
Unhandled rejection JsDom Cannot render urls, please set the browser option to true
➜  air (master) cat .accessibilityrc 
options: {
  browser: true
}

Any tips?

@uandco
Copy link

uandco commented Dec 7, 2018

I'm on the same boat:
JsDom Cannot render urls, please set the browser option to true

But a .accessibilityrc file in the same folder doesn't solve it.

@uandco
Copy link

uandco commented Dec 7, 2018

OK so I debugged this and found out the CLI script was not checking for .accessibilityrc
Here's a patch:
In access-sniff/dist/cli/index.js, add these lines at the top:

var _rc = require('rc'); var _rc2 = _interopRequireDefault(_rc);

then, before new _app2.default(options), add this:
(0, _rc2.default)('accessibility', options);

I tested with a .accessibilityrc file in my user folder on Windows, containing this:
{ "browser": true, "reportLocation": "reports" }

And that did the trick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants