[Bug?]: node-modules - Dependency with different major version in nested workspace not installed

[nicolo-ribaudo]

Self-service

• I'd be willing to implement a fix

Describe the bug

I have two nested packages. The outer one depends on ESLint 7, the inner one on ESLint 8. Only ESLint 7 is installed.

To reproduce

const { writeFile } = require("fs").promises;

await packageJson({
  private: true,
  dependencies: {
    eslint: "^7.0.0"
  }
},{ cwd: "workspace" })

await packageJson({
  private: true,
  dependencies: {
    eslint: "8.0.0-beta.2"
  }
},{ cwd: "workspace/nested" })

await writeFile(".yarnrc.yml", `nodeLinker: node-modules`);
await writeFile("workspace/nested/index.js", `module.exports = require("eslint/package.json").version`);

await packageJsonAndInstall({
  workspaces: ["workspace", "workspace/nested"]
});

const version = await node("workspace/nested/index.js");

expect(version).toBe("8.0.0-beta.2");

If this sherlock reproduction doesn't work, you can clone this branch: https://github.com/nicolo-ribaudo/babel/tree/yarn-bug-missing-dep. The last commit shows the package necessary to introduce the bug; you can run node eslint/babel-eslint-parser/test/eslint-8/index.js and it should print 8.0.0-beta.2.

Environment

System:
    OS: Linux 5.11 Ubuntu 21.04 (Hirsute Hippo)
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 16.8.0 - /tmp/xfs-cc5b8bc4/node
    Yarn: 2.4.1-git.20210125.0f31e6910 - /tmp/xfs-cc5b8bc4/yarn
    npm: 7.21.1 - ~/.npm-global/bin/npm

Additional context

No response

[yarnbot]

This issue reproduces on master:

Error: expect(received).toBe(expected) // Object.is equality

Expected: "8.0.0-beta.2"
Received: {}
    at module.exports (evalmachine.<anonymous>:27:17)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async /github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.2-91650a2501-627bee24a7.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:56:13
    at async executeInTempDirectory (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.2-91650a2501-627bee24a7.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:17:16)
    at async Object.executeRepro (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.2-91650a2501-627bee24a7.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:24:12)
    at async ExecCommand.execute (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-2.0.2-91650a2501-627bee24a7.zip/node_modules/@arcanis/sherlock/lib/commands/exec.js:25:38)
    at async ExecCommand.validateAndExecute (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-91cf93ba72.zip/node_modules/clipanion/lib/advanced/Command.js:161:26)
    at async Cli.run (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-91cf93ba72.zip/node_modules/clipanion/lib/advanced/Cli.js:74:24)
    at async Cli.runExit (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-91cf93ba72.zip/node_modules/clipanion/lib/advanced/Cli.js:83:28)

[merceyz]

Both versions of ESLint is installed but both workspaces get access to the 7.x version due to the layout on disk

.
├── node_modules
│   └── eslint@8
└── workspace
    ├── node_modules
    │   └── eslint@7
    ├── nested
    │   └── package.json
    └── package.json

[arcanis]

Seems to be a valid issue; the workspace/nested copy of eslint shouldn't be hoisted into its parent workspace (probably happens because of having a workspace inside a workspace).

cc @larixer

[larixer]

Seems to be a valid issue; the workspace/nested copy of eslint shouldn't be hoisted into its parent workspace (probably happens because of having a workspace inside a workspace).

The problem is actually different. The workspaces/nested copy is hoisted to the top-level, not to the parent workspace. The eslint copy in the parent workspace is correct. Looking....

[larixer]

@nicolo-ribaudo Just a heads up, I've took a stab to fix this issue at #3438, checked your example and it works for me now. Gotta add integration tests to the PR to prevent future regressions in the following days.