Make secureGitUrl() warn for insecure Urls #5424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #4809. It is rebased to current master and has some new tests added that verify the behavior of the modified
secureGitUrl()
function.Summary
secureGitUrl()
tries to make sure that we use secure URLs. It currently behaves inconsistently, like allowing plain http download without any warnings or raisingSecurityError
if a repository doesn't exist. See #4307 for details.Main changes in behavior with this pull request:
http:
andgit:
URLs are handled consistently:http:
URLs without a commit hash now report a warning. Previously they were silently accepted.git:
URLs without a commit hash now no longer raise a SecurityError. Instead they report a warning.SecurityError
. Previously this happend in some cases, leading to very confusing error messages.For more context/rational see #4307 and the test cases in this pull request.