fix(info): report empty npm response with infoFail again
#5915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was this way before #5903 and it looks like such a response can still happen.
sth
changed the title
infoFailinfoFail again
sth
changed the title
infoFail againinfoFail again
sth
changed the title
infoFail againinfoFail again
|
So now 404 are either empty or an error? 🙁 |
arcanis
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#5903 added support for exceptions thrown by the npm request, but changed handling of empty responses. They are now an invariant violation instead of an expected error reported as
infoFail.But empty responses can still happen. I assume they should continue to be handled like they were before #5903. This pull request makes this change.
Test plan
Tests should still pass and hopefully more reliably than before.