fix(util/fs): use file content instead of mtime to determine equality #6010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm 6 locks mtime of all files in the published tarball to be October 26th 1985, which means mtime is no longer changed when a package is published with an npm version above 6. See: https://npm.community/t/tarball-content-timestamps-locked-to-1985/149 Fixes: yarnpkg#5723
|
I'm sad to see this optimization go, but we won't need it anyway soon 😇 |
arcanis
pushed a commit
to arcanis/yarn
that referenced
this pull request
Aug 1, 2018
…equality (yarnpkg#6010)" This reverts commit c53d039.
Merged
arcanis
added a commit
that referenced
this pull request
Aug 3, 2018
* Revert "fix(util/fs): use file content instead of mtime to determine equality (#6010)" This reverts commit c53d039. * Bumps the cache version * Forces the mtime to be based on the time the archives got fetched * Fixes subseconds time assignment (nodejs/node#22070) * Adds regression tests for #5723 * Fixes tests * Fixes test on architectures that don't support subsecond precision
arcanis
added a commit
that referenced
this pull request
Aug 3, 2018
* Revert "fix(util/fs): use file content instead of mtime to determine equality (#6010)" This reverts commit c53d039. * Bumps the cache version * Forces the mtime to be based on the time the archives got fetched * Fixes subseconds time assignment (nodejs/node#22070) * Adds regression tests for #5723 * Fixes tests * Fixes test on architectures that don't support subsecond precision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
npm 6 locks mtime of all files in the published tarball to be October
26th 1985, which means mtime is no longer changed when a package
is published with an npm version above 6.
See: https://npm.community/t/tarball-content-timestamps-locked-to-1985/149
Fixes: #5723