fix(resolutions): Warn instead of erroring if unmatched dependency matches resolutions with glob support #6033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After running |
ramasilveyra
force-pushed
the
fix/check-resolution
branch
from
99fd373
to
76ef07c
Compare
…tches resolutions with glob support Summary PR yarnpkg#4835 fixed `yarn check` while using simple resolutions keys. This PR fixes `yarn check` while using resolutions keys with globs or dep trees. Test plan New test case added.
ramasilveyra
force-pushed
the
fix/check-resolution
branch
from
76ef07c
to
460ffea
Compare
|
Good for me! Thanks! :) |
arcanis
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR #4835 fixed
yarn checkwhile using simple resolutions keys (likerepeat-string).This PR fixes
yarn checkwhile using resolutions keys with globs (like**/repeat-string) or dep trees (likepad-left/repeat-string).Test plan
New test case added.