Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps hawk #6194

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Bumps hawk #6194

merged 1 commit into from
Aug 1, 2018

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Aug 1, 2018 •
edited by Haroenv
Loading

Summary

Bumps hawk in one of our test fixtures. It doesn't really matter because no code was ever run, but at the very least it will avoid other warnings in the future.

fixes #6191

Test plan

CI

@arcanis arcanis mentioned this pull request Aug 1, 2018
Closed
Haroenv
Haroenv approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes :)

@arcanis arcanis force-pushed the bump-hawk branch 3 times, most recently from 2356a82 to a065305 Compare August 1, 2018 13:06
@arcanis
Copy link
Member Author

arcanis commented Aug 1, 2018

Only error seems flaky, merging:

FAIL  __tests__/integration.js (159.046s)
  ● yarn add https://github.com/yarnpkg/yarn/releases/download/v0.18.1/yarn-v0.18.1.tar.gz

    Command failed: /Users/distiller/project/yarn/bin/yarn add https://github.com/yarnpkg/yarn/releases/download/v0.18.1/yarn-v0.18.1.tar.gz --cache-folder /var/folders/ms/xg67k5sn16xc7sdr_w3q45840000gn/T/d-11871-844-ig0062.yg6d/cache
    error Received malformed response from registry for undefined. The registry may be down.
    Error: Received malformed response from registry for undefined. The registry may be down.

@arcanis arcanis merged commit 94933a8 into master Aug 1, 2018
@Haroenv Haroenv deleted the bump-hawk branch August 1, 2018 15:56
This was referenced Aug 3, 2018
Closed
Closed
Gudahtt added a commit to Gudahtt/yarn that referenced this pull request Aug 5, 2018
@Gudahtt
test(request-cache): Update request-cache hawk version
010ebbc 
The version of `hawk` used in the `upgrade` test was updated recently in yarnpkg#6194 . The new version of
`hawk` and any dependencies should be in the request cache, so that the test suite is faster, more
reliable, and uses less bandwidth.
@Gudahtt Gudahtt mentioned this pull request Aug 5, 2018
Merged
arcanis pushed a commit that referenced this pull request Aug 6, 2018
@Gudahtt @arcanis
test(request-cache): Update request-cache hawk version (#6227)
49446bb 
The version of `hawk` used in the `upgrade` test was updated recently in #6194 . The new version of
`hawk` and any dependencies should be in the request cache, so that the test suite is faster, more
reliable, and uses less bandwidth.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example package used in a test is marked as "insecure" by GitHub
2 participants
@arcanis @Haroenv