ci(perf): Set maxWorkers to match the number of cores available #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
changed the title
AppVeyor VMs have 2 cores, yet we were telling Jest to use 3 workers. Changing it to 2 should reduce overhead and speed up the test suite.
Gudahtt
force-pushed
the
improve-appveyor-test-performance
branch
from
36db3bd
to
944f278
Compare
|
Interesting. The build succeeded both times. Perhaps this setting was responsible for the flakiness we've seen in the Windows tests. Or maybe that's wishful thinking. |
|
|
|
Hmm. It looks like it did help, but some tests are still timing out. Ah well. At least it has improved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AppVeyor VMs have 2 cores, yet we were telling Jest to use 3 workers. Changing it to 2 should reduce
overhead and speed up the test suite.
From the limited testing I've done on AppVeyor, the speed improvement is 10% at best, probably less. But every bit helps, especially when we're seeing tests fail from timeouts.
Test plan
I tested this by running AppVeyor builds. They completed successfully, and were marginally faster on average.