Reverts #2454

[arcanis]

Summary

Cf my comment in #2454 - I'm not certain it fixes anything. I'm not certain there was a problem to begin with 🤔

Test plan

I can make a test if I understand the repro. The existing ones are passing.

[BYK]

Alright, let's hope this doesn't bite us back in the future.

[richard-ejem]

@arcanis I just tried to update a project Yarn 1.9.4 -> Yarn 1.19.1 and it seems this revert broke how we work with links. We have a monorepo where the main package links modules from other folders using yarn link, like this:

~/my-project/library - a standalone yarn package @my-project/library
~/my-project/main - depends on `@my-project/library` and links it using `yarn link @my-project/library`

With Yarn 1.9.4 (before this revert), the link created in ~/my-project/main/node_modules/@my-project/library led directly to ../../../my-project/library.

Now, because the fs.realpathSync call was removed, the symlink leads to another symlink like this: ~/my-project/main/node_modules/@my-project/library -(symlink)-> ../../../../../.config/yarn/link/@my-project/library -(symlink)-> ../../../../my-project/library

This is a problem because I build the app in Docker and the .config/yarn is not even a part of the Docker volume, therefore IDE on my host machine sees the symlinks in node_modules as broken.

Would it be possible to add the capability to resolve the symlinks back?

Update: filed as an issue #7614