fix(resolution): Normalise non-HTTPS NPM registry URLs too #6353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some packages the NPM registry is incorrectly returning tarball URLs that are not using HTTPS. For example: `http://registry.npmjs.org/onetime/-/onetime-1.1.0.tgz` Previously the `registry.npmjs.org` -> `registry.yarnpkg.com` tarball URL normalisation was not occurring for these non-HTTPS URLs, causing unwanted `http://registry.npmjs.org` references in `yarn.lock`. Whilst the real fix needs to be made upstream: https://npm.community/t/some-packages-have-dist-tarball-as-http-and-not-https/285 ...this change prevents lockfile churn and insecure package downloads over HTTP in the meantime. The request-cache entry for `onetime` has been updated to the current NPM registry response, which contains the bogus `tarball` URLs. Fixes #6259.
|
Could someone retrigger the circle-ci |
|
Yeah, we have these errors sometimes. Your PR looks good, thanks! I think that it was supposed to work like that, seeing that we were using |
|
Yeah agreed - suspect it was the intention to handle both from the beginning. |
This was referenced Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For some packages the NPM registry is incorrectly returning tarball URLs that are not using HTTPS. For example:
http://registry.npmjs.org/onetime/-/onetime-1.1.0.tgzPreviously the
registry.npmjs.org->registry.yarnpkg.comtarball URL normalisation was not occurring for these non-HTTPS URLs, causing unwantedhttp://registry.npmjs.orgreferences inyarn.lock.Whilst the real fix needs to be made upstream:
https://npm.community/t/some-packages-have-dist-tarball-as-http-and-not-https/285
...this change prevents lockfile churn and insecure package downloads over HTTP in the meantime.
Fixes #6259.
Test plan
The request-cache entry for
onetimehas been updated to the current NPM registry response, which contains the bogustarballURLs. Running the newly added test without the corrected regex, confirmed the test failed prior to the fix.In addition, running
yarn add [email protected]with yarn 1.9.4 gives ayarn.lockcontaining thehttp://registry.npmjs.org/onetime/...tarball URL, whereas doing the same with a build from this branch giveshttps://registry.yarnpkg.com/onetime/....