Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check why spilling was not enabled in stable 24.4 #11885

Open
lll-phill-lll opened this issue Nov 22, 2024 · 2 comments
Open

Check why spilling was not enabled in stable 24.4 #11885

lll-phill-lll opened this issue Nov 22, 2024 · 2 comments
Assignees
@lll-phill-lll
Labels
area/runtime YDB runtime issues

Comments

@lll-phill-lll
Copy link
Member

https://datalens.yandex/ug26hdjlxoeoi?tab=8J&state=0bab6d40641

Results:
https://proxy.sandbox.yandex-team.ru/7513769566/index.html#suites/83a7db6541269867a604826f8b4fa5ca/d0ce77a080b3f5ad/

according to the svg files nothing was spilled.

Task is to determine the reasons
@lll-phill-lll lll-phill-lll added the area/runtime YDB runtime issues label Nov 22, 2024
@lll-phill-lll lll-phill-lll self-assigned this Nov 22, 2024
@lll-phill-lll
Copy link
Member Author

lll-phill-lll commented Nov 22, 2024 •
edited
Loading

The branch:
https://github.com/ydb-platform/ydb/commits/prestable-24-4/

As far as I see memory fixes are missing here.
To add:

  1. https://github.com/ydb-platform/ydb/pull/10997/files
  2. Put spilling stats in metrics #9282
  3. Wide combiner spill during state split #9785

@lll-phill-lll
Copy link
Member Author

Added commits to stable 24-3: #11889

@lll-phill-lll lll-phill-lll mentioned this issue Nov 22, 2024
Merged
@lll-phill-lll lll-phill-lll changed the title Check why spilling was not enabled in stable Check why spilling was not enabled in stable 24.4 Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lll-phill-lll lll-phill-lll

Labels
area/runtime YDB runtime issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lll-phill-lll