Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Reserve() in GraceJoin #11989

Open
lll-phill-lll opened this issue Nov 26, 2024 · 0 comments
Open

Support Reserve() in GraceJoin #11989

lll-phill-lll opened this issue Nov 26, 2024 · 0 comments
Assignees
@lll-phill-lll
Labels
area/runtime YDB runtime issues

Comments

@lll-phill-lll
Copy link
Member

lll-phill-lll commented Nov 26, 2024 •
edited
Loading

The second step to fix the issue: #11412 (comment)

The goal is to reserve memory for the Join phase of GraceJoin using the method Reserve added here: #11988

GJ must try to reserve Reserve() smallTable*3 bytes before Join and switch to spilling in case of failure.
The suggested place to add the reserve call is:

ydb/yql/essentials/minikql/comp_nodes/mkql_grace_join.cpp

Line 826 in 6b225ec

if (IsSpillingAllowed && ctx.SpillerFactory && IsSwitchToSpillingModeCondition()) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lll-phill-lll lll-phill-lll

Labels
area/runtime YDB runtime issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lll-phill-lll