Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal recent searches persisting across experiences #364

Open
apav-dev opened this issue May 8, 2023 · 0 comments
Open

Universal recent searches persisting across experiences #364

apav-dev opened this issue May 8, 2023 · 0 comments

Comments

@apav-dev
Copy link

apav-dev commented May 8, 2023

Search UI React utilizes local storage to persist local search history for the SearchBar component across sessions. The problem is that all universal searches are saved with the key __yxt_recent_searches_universal__. This means that if you go from universal search on one site to another, you'll see the searches from site 1 appear on site 2.

My suggestion would be to change the key to __yxt_recent_searches_universal__[SEARCH_EXPERIENCE_KEY]

Since the library does not have widespread usage at this point, only devs like myself who develop multiple projects at once using Search UI React are going to notice this issue, but still seems like something that should be addressed. This could be an issue if someone is trying to demo multiple sites with Universal Search implemented with Search UI React.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant