Add missing break to prevent showing toolip on focus when on="hover" #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update tests to use `on` prop instead of `triggerOn` * Add react-testing-library and update tests to test behavior
steevsachs
force-pushed
the
bugfix/focus-event-when-on-hover
branch
from
a0d9dc9 to
af567dd
Compare
|
good catch @steevsachs, your PR will be merged ASAP. |
|
Awesome, @yjose, thank you for the prompt response! Please feel free to request changes on any of those testing changes I made, particularly since I added a library. I originally tried testing with a snapshot and discovered that my snap looked like all the others and didn't prove the resolution. |
|
I will review the PR ASAP, and I already want to move to the react-testing-library for testing from a while now, looks interesting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing
breakto prevent the focus event from triggering the popup whenonis set tohover.To reproduce:
https://codesandbox.io/s/rwkqrokrro
Result: The popup will be visible
I noticed the existing tests were using an invalid
triggerOnprop instead ofon, so I updated that throughoutindex.test.js.I also updated the initial tests to check for rendering behavior because the shallow json snapshot could not guarantee the popup behavior in browser.