Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added disabled prop #50

Merged
merged 3 commits into from
Oct 31, 2018
Merged

Added disabled prop #50

merged 3 commits into from
Oct 31, 2018

Conversation

raRaRa
Copy link
Contributor

@raRaRa raRaRa commented Oct 19, 2018

Added new prop disabled which disables the popup from showing up. It also closes the popup if it's open when disabled is changed from false to true.

Reverted .babelrc changes
Added disabled as false to test snapshots
Added simple test for the new disabled prop - we could probably add more tests around it, such as confirming that it closes the popup when disabled is changed to true
Added disabled to componentApi.md
@raRaRa raRaRa changed the title First commit on the new disabled prop Added disabled prop Oct 20, 2018
@yjose yjose self-requested a review October 20, 2018 14:27
@Saitop
Copy link

Saitop commented Oct 22, 2018

Good job! Please merge this and upgrade. Thanks!

@Saitop
Copy link

Saitop commented Oct 31, 2018

Hey raRaRa, could we fix this and tell the maintainer to update the component?

@raRaRa
Copy link
Contributor Author

raRaRa commented Oct 31, 2018

I've merged the changes. Can you look into this @yjose

Copy link
Owner

@yjose yjose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@yjose yjose merged commit ba910b8 into yjose:master Oct 31, 2018
@yjose yjose mentioned this pull request Oct 31, 2018
@raRaRa
Copy link
Contributor Author

raRaRa commented Oct 31, 2018

Thanks @yjose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants