Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add className to Popup props in typescript #90

Merged
merged 1 commit into from
May 23, 2019
Merged

Conversation

tsurutan
Copy link

Hi @yjose .

Is there any reason to remove 'className' from Popup props in typescript ?
If there is no reason, I want to use 'className' in typescript.

@yjose yjose self-requested a review May 23, 2019 04:17
Copy link
Owner

@yjose yjose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjose
Copy link
Owner

yjose commented May 23, 2019

My bad, I just missed to add it.
Thanks @tsurutan 👍

@yjose yjose merged commit cb62cc0 into yjose:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants