-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filterBcConns = true doesn't work #10
Comments
the same happens to me. |
I suppose I wasn't paying enough attention. That, or the default value in the constructor is should be false, not true - which makes more sense since |
All Yjs connectors use broadcastchannels to exchange document updates efficiently window-to-window. It is a cheap method to exchange document updates when no internet connection is available. It doesn't make sense to me to disable the broadcastchannel (there is no advantage in that). The idea is that a WebRTC connection is only created if the client is not already connected via broadcastchannel. Therefore, But you are right @areebbeigh . The mentioned section is wrong. |
Using
filterBcConns: true
in options still uses broadcast channels instead of a webrtc connection for tabs in the same browser. Tested onChrome: Version 79.0.3945.79 (Official Build) (64-bit)
andFirefox: 74.0 (64-bit)
on Ubuntu 18.04The text was updated successfully, but these errors were encountered: