Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider epsilon used for is_approx_zero #97

Open
Imberflur opened this issue Nov 12, 2024 · 0 comments
Open

Reconsider epsilon used for is_approx_zero #97

Imberflur opened this issue Nov 12, 2024 · 0 comments

Comments

@Imberflur
Copy link
Contributor

In #48 I made is_approx_zero use the same is_magnitude_close_to method that is used to check if something is normalized.

The primary use I know of for is_approx_zero is checking if a vector can be normalized which is possible for values much closer to zero than what is_magnitude_close_to checks for (in is_normalized we needed a larger range to cover all normalized vectors).

So I'm wondering if this should be reconsidered? I don't have any pressing use case for this. Just realized this when looking back over #48 and wanted to document it in an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant