You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #48 I made is_approx_zero use the same is_magnitude_close_to method that is used to check if something is normalized.
The primary use I know of for is_approx_zero is checking if a vector can be normalized which is possible for values much closer to zero than what is_magnitude_close_to checks for (in is_normalized we needed a larger range to cover all normalized vectors).
So I'm wondering if this should be reconsidered? I don't have any pressing use case for this. Just realized this when looking back over #48 and wanted to document it in an issue.
The text was updated successfully, but these errors were encountered:
In #48 I made
is_approx_zero
use the sameis_magnitude_close_to
method that is used to check if something is normalized.The primary use I know of for
is_approx_zero
is checking if a vector can be normalized which is possible for values much closer to zero than whatis_magnitude_close_to
checks for (inis_normalized
we needed a larger range to cover all normalized vectors).So I'm wondering if this should be reconsidered? I don't have any pressing use case for this. Just realized this when looking back over #48 and wanted to document it in an issue.
The text was updated successfully, but these errors were encountered: