-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSelenium/carbonate Windows #15
Comments
it looks like an |
I don't have a windows OS on hand. the only place RSelenium is being 'setup' is here and here. In the latter the I have a feeling that @juyeongkim would have a quicker answer on that. |
@juyeongkim I can provide more info and we can move this convo to the RSelenium repo if you want. |
@maelle i just ran it on my OS it gets the same thing as you. the carbon page must have changed. I'll reset the xpaths (not the first time that page has been changed). Thanks for catching this. |
Ah very cool! Happy to be of help, looking forward to getting PNGs! 🎉 |
The ci passed. So once you verify for windows I’ll pr this branch. |
Installing now! |
Yay it worked! Thanks! Btw have you thought of wrapping the source code of carbon.js itself to create the pic locally? Is it even possible? |
Actually an image was created, but not saved to disk, is this normal? |
i.e. I then had to run |
(and sorry for all the questions... such a neat package!!) |
great questions :). using the carbon.js script was my first instinct too to create an htmlwidget, but they dont give access to the raw script (only throught the website). the default to save to disk is x$chrome_pref$download.default_directory <- MYPATH example from the readme |
Interesting! Now I wonder about the possibility to make a similar, less pretty/customizable tool via Oops sorry for not reading the docs enough! Would it make sense for x$carbonate(file = 'myfile.png', dir = getwd()) with |
That would be nice, but chrome pref controls The download dir. what may work is to have an exposed method that wraps around that nested element to simplify the api. The first comment about using magick instead sounds like a big undertaking, carbonjs is pretty complex to mimic (at least for me ;)) |
Reread your dir suggestion. Could work, but I’m not next to a computer for most of the day. Your welcome to fork and play around with it. Improving the api is always welcome. |
Reg the non-carbonate solution, do you know of https://github.com/ropenscilabs/codefinch? It uses rendering to PDF and then rendering of the PDF to an image (via Will make a small try for the |
sorry I won't have time to do the |
No worries, I’ll take a look tonight. |
I think user experience would increase once headless chrome download to location bug is fixed. |
Awesome, thank you! |
removed the output_dir. it was causing trouble with the RSelenium driver since the directory is being set at the self$start. The way it was (while more cumbersome) is more robust and less prone to errors. |
Describe the bug
I can't take a screenshot of the object.
To Reproduce
Created on 2018-09-29 by the reprex package (v0.2.1)
Session info
The text was updated successfully, but these errors were encountered: