Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.21.1 AppImage: inside Addon Manager, link to NativeIFC addon fails to render #124

Open
pawsey-kbuckley opened this issue Nov 29, 2023 · 5 comments

Comments

@pawsey-kbuckley
Copy link

0.21.1 AppImage: inside Addon Manager, link to NativeIFC addon fails to render

When you open up the Addon Manager and select the BIM addon, it renders,
or rather it says it is rendering the README.md from

https://github.com/yorikvanhavre/BIM_Workbench/blob/master/README.md

and within that text, there a link to the NativeIFC addon which is

https://github.com/yorikvanhavre/FreeCAD-NativeIFC/tree/main

however, clicking on that link inside the Addon Manager results in a
nessage that says

Could not load README data from URL https://github.com/yorikvanhavre/FreeCAD-NativeIFC/tree/main

although, within GitHub, the link does take you to the right place.

Wierd!

@pawsey-kbuckley
Copy link
Author

Bit of extra data, in that, what I saw on the console from which I had
invoked the AppImage, were the following lines:

``
"Empty widget item in QVBoxLayout 'verticalLayout'."
[25795:25921:1129/161406.524819:ERROR:nss_util.cc(283)] After loading Root Certs, loaded==false: NSS error code: -8018
Release of profile requested but WebEnginePage still not deleted. Expect troubles !
Release of profile requested but WebEnginePage still not deleted. Expect troubles !
Release of profile requested but WebEnginePage still not deleted. Expect troubles !
Release of profile requested but WebEnginePage still not deleted. Expect troubles !

@yorikvanhavre
Copy link
Owner

yorikvanhavre commented Dec 1, 2023

Is the addon manager able to open links in readme's at all? @chennes ?

@pawsey-kbuckley
Copy link
Author

Don't really have a definitive answer for you: apologies.

If I click on a link within the BIM "readme" I do get moved around with the readme,
although it's not clear that I'm moved to the correct target/anchor, but the external
link, to the IFC URI still fails, however,

if I open up the BCF Plugin, and click on the FreeCAD link in there, I do get taken to
a page outside of the BCF Plugin README.

HTH

@chennes
Copy link
Contributor

chennes commented Dec 5, 2023

It's supposed to launch those links in your system web browser, it's possible something got broken there.

@yorikvanhavre
Copy link
Owner

yorikvanhavre commented Dec 11, 2023

It seems to open the link briefly in the same window (inside the addon manager). What I can see so far:

  • non-github links open in the desktop browser
  • github links keep opening in the addon manager, but they get parsed with the markdown converter
    I think the best solution is to make sure only links ending with .md get parsed with the markdown converter, the others should be opened in the defautl browser too... I'll have a look at it later

EDIT it should happen somewhere in https://github.com/FreeCAD/FreeCAD/blob/main/src/Mod/AddonManager/package_details.py but I can't nail it... would love some help 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants