Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Waker::clone_from internally #160

Closed
yoshuawuyts opened this issue Nov 6, 2023 · 0 comments · Fixed by #161
Closed

Use Waker::clone_from internally #160

yoshuawuyts opened this issue Nov 6, 2023 · 0 comments · Fixed by #161
Labels
good first issue Good for newcomers

Comments

@yoshuawuyts
Copy link
Owner

Now that rust-lang/rust#96979 has been merged, we should use Waker::clone_from in our set_waker functions to remove reduce unnecessary clones. If done right, then from now on we'll typically only clone-on-wake the first time our concurrency types are polled.

This should be relatively simple to implement, so anyone who wants to pick it up should feel free to. It would also be interesting to bench this on nightly, which should have these changes starting ~tomorrow.

@yoshuawuyts yoshuawuyts added the good first issue Good for newcomers label Nov 6, 2023
@yoshuawuyts yoshuawuyts changed the title Use Waker::clone_from Use Waker::clone_from internally Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant