Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/GameDevTV] Add extractor #11368

Merged
merged 12 commits into from
Nov 6, 2024
Merged

Conversation

stratus-ss
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Adds support for gamedev.tv

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

@bashonly bashonly added the site-request Request to support a new website label Oct 27, 2024
@stratus-ss stratus-ss marked this pull request as draft October 27, 2024 23:54
@bashonly bashonly marked this pull request as ready for review October 29, 2024 23:40
@bashonly bashonly added the pending-review PR needs a review label Oct 29, 2024
yt_dlp/extractor/gamedevtv.py Outdated Show resolved Hide resolved
@seproDev seproDev added pending-fixes PR has had changes requested and removed pending-review PR needs a review labels Nov 1, 2024
Copy link
Member

@seproDev seproDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I would have done

yt_dlp/extractor/gamedevtv.py Outdated Show resolved Hide resolved
yt_dlp/extractor/gamedevtv.py Outdated Show resolved Hide resolved
yt_dlp/extractor/gamedevtv.py Outdated Show resolved Hide resolved
yt_dlp/extractor/gamedevtv.py Show resolved Hide resolved
yt_dlp/extractor/gamedevtv.py Outdated Show resolved Hide resolved
@stratus-ss
Copy link
Contributor Author

This is what I would have done

I've tested and implemented your suggestion. Thank you very much!

@stratus-ss stratus-ss requested a review from seproDev November 6, 2024 14:58
@seproDev seproDev added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Nov 6, 2024
@seproDev seproDev changed the title [GameDevTV] add extractor [ie/GameDevTV] Add extractor Nov 6, 2024
yt_dlp/extractor/gamedevtv.py Outdated Show resolved Hide resolved
yt_dlp/extractor/gamedevtv.py Outdated Show resolved Hide resolved
@seproDev seproDev removed the pending-review PR needs a review label Nov 6, 2024
@bashonly bashonly merged commit be3579a into yt-dlp:master Nov 6, 2024
6 checks passed
vladisslav2011 pushed a commit to vladisslav2011/yt-dlp that referenced this pull request Jan 30, 2025
Authored by: stratus-ss, bashonly

Co-authored-by: bashonly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants