new rule: may use asynchronous processing #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmilyOrg
reviewed
Nov 17, 2023
SmilyOrg
reviewed
Nov 17, 2023
SmilyOrg
reviewed
Nov 17, 2023
SmilyOrg
reviewed
Nov 17, 2023
Co-authored-by: Miha Lunar <[email protected]>
Co-authored-by: Miha Lunar <[email protected]>
|
👍 |
tkrop
reviewed
Nov 21, 2023
There was a problem hiding this comment.
Hi @tfrauenstein, sorry for the delay. Please see my inline comments and suggestions for improving.
Co-authored-by: Tronje Krop <[email protected]>
Co-authored-by: Tronje Krop <[email protected]>
Co-authored-by: Tronje Krop <[email protected]>
Co-authored-by: Tronje Krop <[email protected]>
tkrop
reviewed
Nov 21, 2023
tkrop
reviewed
Nov 21, 2023
tkrop
reviewed
Nov 21, 2023
Co-authored-by: Tronje Krop <[email protected]>
Co-authored-by: Tronje Krop <[email protected]>
Co-authored-by: Tronje Krop <[email protected]>
|
👍 |
1 similar comment
|
👍 |
tkrop
added a commit
that referenced
this pull request
Nov 22, 2023
Signed-off-by: tkrop <[email protected]>
tkrop
added a commit
that referenced
this pull request
Nov 22, 2023
Signed-off-by: tkrop <[email protected]>
tkrop
added a commit
that referenced
this pull request
Nov 22, 2023
Signed-off-by: tkrop <[email protected]>
tkrop
added a commit
that referenced
this pull request
Dec 12, 2023
SmilyOrg
added a commit
that referenced
this pull request
Feb 29, 2024
* feat: improve response code guidance (#787, #762, #737) Signed-off-by: tkrop <[email protected]> * Add suggested changes from API guild discussion * Apply suggestions from code review Co-authored-by: Tronje Krop <[email protected]> * Remove break * Make POST section more concise with bullet points * Integrate newer text copy into the updated bullet points * Move bullet points relevant to single resources under single resources --------- Signed-off-by: tkrop <[email protected]> Co-authored-by: tkrop <[email protected]> Co-authored-by: Miha Lunar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in the API Guild: Provides best practices for REST design of asynchronous processing and clarifies uncertainties about response codes in still ongoing processing situations.