Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc language edits - "Deep Learning" and "Guides" #786

Merged
merged 13 commits into from
Jul 24, 2024
Merged

Doc language edits - "Deep Learning" and "Guides" #786

merged 13 commits into from
Jul 24, 2024

Conversation

yuxizama
Copy link
Contributor

@yuxizama yuxizama commented Jul 8, 2024

docs: language edits

@cla-bot cla-bot bot added the cla-signed label Jul 8, 2024
yuxizama
yuxizama commented Jul 8, 2024
View reviewed changes
Copy link
Contributor Author

@yuxizama yuxizama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zama-ai/machine-learning
There are some changes needed in this PR, I marked them in comments. (Seems like I can not request changes as the author of the PR)
Please have a look. Thanks!

docs/getting-started/concepts.md Outdated Show resolved Hide resolved
docs/deep-learning/fhe_assistant.md Outdated Show resolved Hide resolved
docs/deep-learning/fhe_assistant.md Outdated Show resolved Hide resolved
@yuxizama yuxizama changed the title Doc language edits - "Deep Learning" Doc language edits - "Deep Learning" and "Guides" Jul 9, 2024
@yuxizama yuxizama marked this pull request as ready for review July 15, 2024 08:25
@yuxizama yuxizama requested a review from a team as a code owner July 15, 2024 08:25
kcelia
kcelia previously approved these changes Jul 24, 2024
View reviewed changes
kcelia
kcelia approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@kcelia kcelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks

@kcelia kcelia merged commit d675ad2 into main Jul 24, 2024
16 checks passed
@kcelia kcelia deleted the doc-edits-2 branch July 24, 2024 13:31
kcelia added a commit that referenced this pull request Jul 24, 2024
@kcelia
Revert "Doc language edits - "Deep Learning" and "Guides" (#786)"
640d4e8 
This reverts commit d675ad2.
fd0r pushed a commit that referenced this pull request Jul 24, 2024
@yuxizama @fd0r
docs: language edits - "Deep Learning" and "Guides" (#786)
1988936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-stoian-zama andrei-stoian-zama andrei-stoian-zama left review comments

@kcelia kcelia kcelia approved these changes

@RomanBredehoft RomanBredehoft Awaiting requested review from RomanBredehoft

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuxizama @kcelia @andrei-stoian-zama