Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently apply secrets & image mutations #334

Closed
RothAndrew opened this issue Feb 16, 2022 · 0 comments · Fixed by #306
Closed

Consistently apply secrets & image mutations #334

RothAndrew opened this issue Feb 16, 2022 · 0 comments · Fixed by #306
Assignees
Labels
enhancement ✨ New feature or request
Milestone

Comments

@RothAndrew
Copy link
Contributor

RothAndrew commented Feb 16, 2022

As a user of Zarf I want the ability to write up my manifests/charts/kustomizations without needing to spend a lot of time modifying them to use Zarf's internal registry instead of the upstream registry, so that I can more easily use existing configurations without having to change them.

Example: My deployment specifies Docker Hub and registry1.dso.mil for all my image paths, which would completely break in an airgap since those locations are not reachable.

Notes:

  • We want to do this in a way that minimizes "magical" behavior. Doing this consistently one way across the entire cluster helps us easily explain what is happening
  • Keep in mind that the Zarf registry requires an imagePullSecret since it hosts its images behind authn/authz

Acceptance Criteria:

  • The Kubernetes Mutating Webhook pattern is used to accomplish this outcome of automatically changing all image definitions such that the Zarf registry is used instead of the upstream registry.
  • By default, the cluster automatically mutates ALL image definitions
  • I can override the behavior and have individual image definitions not be mutated by applying some label/annotation/flag
@RothAndrew RothAndrew moved this to New Requests in Zarf Project Board Feb 16, 2022
@RothAndrew RothAndrew moved this from New Requests to Doing Now in Zarf Project Board Feb 16, 2022
@jeff-mccoy jeff-mccoy linked a pull request Feb 16, 2022 that will close this issue
@jeff-mccoy jeff-mccoy added enhancement ✨ New feature or request helm labels Feb 25, 2022
@jeff-mccoy jeff-mccoy pinned this issue Feb 28, 2022
@YrrepNoj YrrepNoj unpinned this issue Mar 7, 2022
@jeff-mccoy jeff-mccoy added this to the Zarf GA milestone Mar 7, 2022
@jeff-mccoy jeff-mccoy moved this from Doing Now to Ready to Start in Zarf Project Board Mar 8, 2022
@YrrepNoj YrrepNoj self-assigned this Mar 16, 2022
@YrrepNoj YrrepNoj removed their assignment Mar 27, 2022
@jeff-mccoy jeff-mccoy pinned this issue Apr 1, 2022
Repository owner moved this from Ready to Start to Done in Zarf Project Board May 19, 2022
@jeff-mccoy jeff-mccoy unpinned this issue May 23, 2022
@Racer159 Racer159 moved this to Done in Zarf Project Board Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants