Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find an elegant way to determine the ARCH in the Makefile. #399

Closed
jeff-mccoy opened this issue Mar 15, 2022 · 3 comments
Closed

Find an elegant way to determine the ARCH in the Makefile. #399

jeff-mccoy opened this issue Mar 15, 2022 · 3 comments
Labels
good first issue 🥇 Good for newcomers

Comments

@jeff-mccoy
Copy link
Contributor

We'll need to add an issue to find an elegant way to determine the ARCH in the Makefile.

The current way doesn't break local e2e testing on arm architectures, but it will be slower because they will always build all the packages as part of the make test-e2e

Originally posted by @YrrepNoj in #392 (review)

@anoncam
Copy link

anoncam commented Mar 18, 2022

An alternate to uname on mac is the arch command. So after your initial ifeq ... Darwin ... you can use a single arch command to get the processor architecture arm, arm64 or amd64/i386...

The outputs here kinda illustrate what I'm trying to relay:

➜  zsh-z git:(develop) uname -s
Darwin
➜  zsh-z git:(develop) uname -p
arm
➜  zsh-z git:(develop) # arm may be too generic
➜  zsh-z git:(develop) arch
arm64

@anoncam
Copy link

anoncam commented Mar 24, 2022

roger that. i'll take a look at the pipelines

@jeff-mccoy
Copy link
Contributor Author

I think this was reasonable handled in #428 by allowing default + overrides for the arch coming into the makefile.

Repository owner moved this from New Requests to Done in Zarf Project Board Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 🥇 Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants