Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile #135

Closed
ShawSumma opened this issue Jun 14, 2022 · 7 comments · Fixed by caius/zed-make#1
Closed

Makefile #135

ShawSumma opened this issue Jun 14, 2022 · 7 comments · Fixed by caius/zed-make#1
Labels
language A request to add a language extension

Comments

@ShawSumma
Copy link

Is your feature request related to a problem? Please describe.
I do not have syntax highlighting on makefiles, this makes typos and other issues easy to miss.

Describe the solution you'd like
Makefile highlighting support

Describe alternatives you've considered
For now the alternative is to go without highlighting

Additional context
Makefiles are essential to a large number of C projects, having syntax highlighting support would make dealing with their quirks much better.
@fdionisi
Copy link

Duplicate of zed-industries/zed#5437

@JosephTLyons JosephTLyons mentioned this issue Jun 14, 2022
Closed
@JosephTLyons
Copy link
Collaborator

I went ahead and closed the original, this one is a bit cleaner. I'll cast my 👍 on this one.

@as-cii as-cii mentioned this issue Aug 1, 2022
Closed
46 tasks
@AssertionBit AssertionBit mentioned this issue Jan 24, 2024
Closed
1 task
@tekumara
Copy link

Similar to vscode it would be nice if Zed could generate hard tabs when working in a Makefile despite hard_tabs = false.

@petros petros changed the title Add Makefile suppport Add Makefile support Mar 17, 2023
@JosephTLyons JosephTLyons added the language A request to add a language extension label Apr 6, 2023
@JosephTLyons JosephTLyons changed the title Add Makefile support Makefile support Apr 6, 2023
@und3fined
Copy link

Any update or have a plan for end of 2023?

@hovsater
Copy link

No update just yet. We'll make sure to post something here when there's news to share. 🙂

@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@JosephTLyons JosephTLyons mentioned this issue Feb 8, 2024
Closed
@JosephTLyons JosephTLyons changed the title Makefile support Makefile Feb 26, 2024
@JosephTLyons JosephTLyons transferred this issue from zed-industries/zed Feb 26, 2024
@JosephTLyons JosephTLyons mentioned this issue Jan 25, 2024
Closed
1 task
@caius caius mentioned this issue Feb 27, 2024
Merged
4 tasks
@drornir
Copy link

drornir commented Apr 13, 2024

The make extension has been fixed! https://github.com/caius/zed-make/releases/tag/v1.0.0
I think this issue can be closed

@ShawSumma
Copy link
Author

That sounds reasonable.

I'll close it now, feel free to reopen if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language A request to add a language extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initial implementation caius/zed-make
7 participants
@tekumara @hovsater @und3fined @fdionisi @drornir @JosephTLyons @ShawSumma