-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL #149
Comments
Is this something we could help contribute? |
Not until there’s a plug-in API available. |
@hovsater ok, is there an issue we can track for that? |
Yeah, there’s zed-industries/zed#5269 currently tracking that. 🙂 |
I'd also like to have Relay LSP support (which is done by an extension in VSCode) which can be utilized by calling the Relay compiler binary with the |
Why not add GraphQL support natively instead of plugins? |
We will be going open source FairlySoon™️. After that, users will be able to propose languages we should bake into the editor, open PRs to do so, or help out with a plugin system so that we can have language extensibility! |
when you say "users will be able to propose languages", does this now count as a language proposal? because this would be really nice to have. |
In the micro, this lack of language-specific syntax highlighting is my biggest deal breaker for adopting Zed. I like the editor and its performance is excellent. However, without a plugin system or some way to extend the editor issues like this will continue to spoil adoption rates. |
Zed extensions was just launched today, so there's an opportunity to add a GraphQL language extension! |
It looks like not having a well-maintained Tree-sitter parser for GraphQL is the biggest blocker right now, since the official GraphQL syntax extension for VSCode is based on TextMate grammar |
I made an extension with the parser recommended by tree-sitter website. Not sure how good the parser is but it seems to be not maintained anymore. If you find any bugs with parsing/highlighting you can report them in extenion's repo. I am going to work on it |
could we get this to support graphql inline and not just graphql files? In typescript on vscode we get this with the gql function and things like this leading comment |
Maybe feels like a separate, general, extension for setting another language/grammar on a block inside of an existing grammar? |
The following is almost a workaround (the fatal flaw is that it de-registers the TypeScript LSP):
- "GraphQL": "languages/graphql"
+ "GraphQL": "languages/graphql",
+ "TSX": "languages/tsx",
+ "TypeScript": "languages/typescript" |
The GraphQL extension was added in #91. Going to close this issue out. Any further requests/issues can be directed to the extension repo: https://github.com/11bit/zed-extension-graphql. |
Check for existing issues
Language
graphql
Tree Sitter parser link
No response
Language server link
https://github.com/graphql/graphiql/tree/main/packages/graphql-language-service-server
Misc notes
No response
The text was updated successfully, but these errors were encountered: