Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocomplete isn't as good in .tsx as in .ts files #8812

Closed
1 task done
petter opened this issue Mar 4, 2024 · 2 comments
Closed
1 task done

autocomplete isn't as good in .tsx as in .ts files #8812

petter opened this issue Mar 4, 2024 · 2 comments
Labels
bug [core label] language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors stale Label used by `stale` action tsx TypeScript JSX support

Comments

@petter
Copy link

petter commented Mar 4, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Having issues using autocomplete in .tsx files. The steps to reproduce provided below is an example of it not working when referencing interface fields, but the autocomplete is in general worse in .tsx files compared to .ts files.

Autocomplete still works for some features, such as destructuring, so it isn't entirely turned off in .tsx files.

Have tried reinstalling typescript-language-server as suggested in #4628 (comment), but this does not seem to fix this issue for me.

  1. Create a .tsx file.
  2. Import some interface from another file
  3. Try using autocomplete to reference a field in the interface, i.e.: MyType['someField']
  4. Observe no autocomplete help
  5. Create a .ts file
  6. Repeat steps above
  7. Observe autocomplete now working

Environment

Zed: v0.124.8 (Zed)
OS: macOS 14.3.0
Memory: 64 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

2024-03-04 09 01 44

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

https://pastebin.com/P8dG1dZy

@petter petter added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Mar 4, 2024
@Moshyfawn Moshyfawn added typescript TypeScript programming language support language An umbrella label for all programming languages syntax behaviors language server An umbrella label for all language servers tsx TypeScript JSX support and removed triage Maintainer needs to classify the issue typescript TypeScript programming language support labels Mar 5, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Mar 5, 2024
Copy link

Hi there! 👋
We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. Are you able to reproduce this issue in the latest version of Zed? If so, please let us know by commenting on this issue and we will keep it open; otherwise, we'll close it in a week. Feel free to open a new issue if you're seeing this message after the issue has been closed.
Thanks for your help!

@github-actions github-actions bot added the stale Label used by `stale` action label Sep 24, 2024
Copy link

github-actions bot commented Oct 8, 2024

This issue was closed due to inactivity; feel free to open a new issue if you're still experiencing this problem!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors stale Label used by `stale` action tsx TypeScript JSX support
Projects
None yet
Development

No branches or pull requests

3 participants