New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable standard/no-callback-literal rule #19

Merged

zeke merged 1 commit into master from disable-no-callback-literal

Jun 10, 2017

Owner

zeke commented Jun 10, 2017

Allow code to have a callback that doesn't have err as first arg:

const {app} = require('electron')

app.on('certificate-error', (event, webContents, url, error, certificate, callback) => {
  if (url === 'https://github.com') {
    callback(true)
  } else {
    callback(false)
  }
})

Making this exception to accommodate Electron APIs.


          disable standard/no-callback-literal rule

8e4fd85

zeke merged commit 573f7cd into master

zeke deleted the disable-no-callback-literal branch

June 10, 2017 19:12

Owner Author

zeke commented Jun 10, 2017

❯ np major 
 ✔ Prerequisite check
 ✔ Git
 ✔ Cleanup
 ✔ Installing dependencies using Yarn
 ✔ Running tests
 ✔ Bumping version using Yarn
 ✔ Publishing package
 ✔ Pushing tags

 standard-markdown 4.0.0 published 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet