Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to read colors when using Gruvbox Light theme. #2790

Closed
papey opened this issue Sep 16, 2023 · 4 comments
Closed

Hard to read colors when using Gruvbox Light theme. #2790

papey opened this issue Sep 16, 2023 · 4 comments

Comments

@papey
Copy link
Contributor

papey commented Sep 16, 2023

Hi 👋

I'm having some issues with the Gruvbox Light color theme in Zellij (zellij 0.38.1)

My config is pretty simple :

theme "gruvbox-light"

And I get

2023-09-16-180123_1080x196_scrot

It's almost impossible to read. I have tried multiple terminal (without a big hope to be honest) and it was the same behavior on all of them. I can rework a bit if you want just let me know.

Thanks a lot.

@papey
Copy link
Contributor Author

papey commented Sep 17, 2023

Ok, so, the color causing the issue is the fg one, I have changed it to fg "#665C54" (fg3, from Gruvbox). I can be changed to fg4 for even better clarity. I'll make a PR for that soon.

@papey
Copy link
Contributor Author

papey commented Sep 26, 2023

👍

@papey papey closed this as completed Sep 26, 2023
@apraga
Copy link

apraga commented Jan 21, 2024

I would like to re-open this issue if possible. Using alacritty's gruvbox-light theme and zellij gruvbox-light :

  1. Pressing Ctrl gives text very hard to read on the different menu :
    zellij-gruvbox-light

  2. The top banner is on a black background but I would expect a light background (like catppuccin-latte). Is that by design ?
    zellij-gruvbox-light-2

Gruvbox-dark does not have, on the contrary, these issues. I am using zellij 0.39.2. Any idea about this ?
Thanks,

@papey
Copy link
Contributor Author

papey commented Jan 24, 2024

Hi @apraga

I did not modify any of this in my PR IIRC. I think most of the light theme is based ok dark one modified, so there are still progress polish it a bit. If you want you can open a PR, look at mine for inspiration about how to tweak colors. Cheers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants