Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary continue #1077

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Remove unnecessary continue #1077

merged 1 commit into from
Feb 24, 2022

Conversation

ken-matsui
Copy link
Contributor

This PR simplifies the if statement in zellij-server/src/wasm_vm.rs.

tlinford
tlinford reviewed Feb 23, 2022
View reviewed changes
Copy link
Contributor

@tlinford tlinford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree this is not great, personally i think i would prefer keeping the if continue, and removing the else, kind of an early return and unindent the real logic?

@ken-matsui
Copy link
Contributor Author

ken-matsui commented Feb 23, 2022 •
edited
Loading

@tlinford
I appreciate your review :) I agree that would be better and more robust against changes and committed new change you've suggested.

@tlinford tlinford merged commit 346e093 into zellij-org:main Feb 24, 2022
@ken-matsui ken-matsui deleted the remove-unnecessary-continue branch February 24, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlinford tlinford tlinford left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ken-matsui @tlinford