refactor(tab): simplify mouse hold and release #1185

tlinford · 2022-03-06T21:07:13Z

Simplify some code around mouse handling:

remove unnecessary Option for position when ending selection, and return None when Grid has empty selection
simplify Tab mouse release and hold handlers
when a selection is initiated in a floating pane, and the mouse leaves the floating pane the selection stays active, instead of starting to move the pane

tlinford temporarily deployed to cachix March 6, 2022 21:07 Inactive

tlinford temporarily deployed to cachix March 7, 2022 13:11 Inactive

tlinford temporarily deployed to cachix March 7, 2022 14:55 Inactive

tlinford added 4 commits March 7, 2022 16:07

refactor(tab): simplify mouse hold and release

49d65a0

do not drag floating pane while selecting

22fcefc

do not copy empty selection

2a56afc

minor adjustments

7b5e003

tlinford force-pushed the refactory-simplify-tab-mouse branch from e433944 to 7b5e003 Compare March 7, 2022 15:10

tlinford temporarily deployed to cachix March 7, 2022 15:10 Inactive

tlinford merged commit 7de7753 into main Mar 8, 2022

tlinford deleted the refactory-simplify-tab-mouse branch March 8, 2022 17:26

Provide feedback