-
-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve theme usage + add default ones #1274
Conversation
Yeah I switched the background color of the status bar from gray to black (since gray is removed no longer specified in the theme). Maybe we can set a lighter shade of black in the default_palette, if that's better? |
Hum - would that affect other stuff? Do we use this black color somewhere else in our UI? |
Hmm... still not great. I just feel it would be a pity if we have to change our UI because we changed our API. Do you feel there's no other way? |
I don't think there's a way to maintain our current default UI other than by "hacking" the plugin specifically for when the default color palette is used. This may also confuse the user since the background and text color would be different when using the default theme and would be the same when using a user-defined theme. Users would expect the same behaviour when using themes. |
Okay, that's fair. I understand the tradeoffs now and when you put it this way, I totally agree. Let's go with 236. Otherwise this LGTM. Great work on this! Merge whenever you're ready :) |
Thanks for adding themes. My Zellij usage can now start - with a theme that works for a light terminal. 🙂 |
Samples-
Solarized Dark
One Half Dark
Molokai Dark
Gruvbox Light
Gruvbox Dark
Dracula