fix osc params 1024 bytes limit #1711
Conversation
* vte's default includes no_std, and in that case the osc params buffer is capped at 1024 bytes
|
@imsnif you ok with updating to vte 0.11.0? |
|
Hey, I'm afk so can't check, but are you sure this is the fix for the bug?
I was debugging this a little yesterday, tried this upgrade and it didn't
work.
I seemed to reach the base64 decoding as a possible direction.
Could be that I was super tired and missed something though. If this fixes
it for you, go for it.
…On Sat, Sep 3, 2022, 2:20 PM Thomas Linford ***@***.***> wrote:
@imsnif <https://github.com/imsnif> you ok with updating to vte 0.11.0?
the only diff is a bugfix, and increased rust version requirement.
—
Reply to this email directly, view it on GitHub
<#1711 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGCHTRQ7BRA6CAHXZN25WDV4M7CRANCNFSM6AAAAAAQD4CWGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The version update fixes a different bug (Fixed infinite loop in Params iterator when 32nd parameter is a subparameter), the fix is the default-features=false :) |
turn off default-features for vte, since default includes no_std, and in that case the osc params buffer is capped at 1024 bytes.
Fixes #1709