Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Modern development environments, especially those utilizing Neovim or Helix, frequently rely on the Language Server Protocol (LSP) to use the undercurl style for feedback. This underlining style, prevalent in many spell checkers over time, serves as an intuitive indicator for mistakes and errors. Recognizing its broad acceptance and utility, I am convinced of the importance of undercurl support for Zellij. The absence of this feature could significantly impact my continued engagement with the project.
Scope and Implementation
While I recognize the diverse underline styles supported by various terminal emulators (including double, curly, dotted, and dashed), the prominence and functionality of undercurl make it a priority. Hence, this PR exclusively addresses the implementation of undercurl.
Related Issues
#1594
#2287
Tests
I've tested this implementation manually with Kitty and Alacritty
Kitty NeoVim:
Alacritty NeoVim:
Kitty Terminal:
Alacritty Terminal: