ZF3 #213

samsonasik · 2016-06-24T19:43:37Z

cherry-pick #210 with incorporated feedbacks.

michalbundyra · 2016-06-24T21:43:30Z

src/ZendDeveloperTools/Listener/ToolbarListener.php

-            array($this, 'onCollected'),
-            Profiler::PRIORITY_TOOLBAR
-        );
+        $this->listeners[] = $events->getSharedManager()->attach('profiler', ProfilerEvent::EVENT_COLLECTED, array($this, 'onCollected'), Profiler::PRIORITY_TOOLBAR);


can we use please short array syntax?

michalbundyra · 2016-06-24T22:03:34Z

michalbundyra · 2016-06-25T06:44:58Z

.travis.yml

-matrix:
-  allow_failures:
-    - php: 7.0
+  - ./vendor/bin/phpunit


one empty line at the and of the file plz

samsonasik · 2016-06-25T06:46:31Z

@webimpress some feedbacks incorporated. I think phpcs checks and some documentation should be in separate PR :)

michalbundyra · 2016-06-25T06:46:42Z

src/Listener/ToolbarListener.php

    }
-
+    


remove white characters please

samsonasik · 2016-06-25T06:48:53Z

@webimpress updated.

samsonasik · 2016-06-25T06:52:43Z

@webimpress implemented.

michalbundyra · 2016-06-25T06:59:13Z

@samsonasik good work! 😄 Thanks!

Can we update please .travis.yml to test library over different version of php and different packages version (lowest, locked, latest), as we have here (for example):
https://github.com/zendframework/zend-view/blob/master/.travis.yml#L25-L69

I'd like to have also trailing commas in arrays (once you changed it to short syntax).

What do you think? BTW. Why you think phpcs checks should be separate PR?

samsonasik · 2016-06-25T07:09:01Z

The original PR is to get it support for zf3.

Original reasons: I have no chance to add phpcs check right now ( need to play with my sons ) :)

Warm regards,

Abdul Malik Ikhsan

Pada 25 Jun 2016, pukul 13.59, webimpress [email protected] menulis:

@samsonasik good work! 😄
Can we update please .travis.yml to test library over different version of php and different packages version (lowest, locked, latest), as we have here (for example):
https://github.com/zendframework/zend-view/blob/master/.travis.yml#L25-L69

I'd like to have also trailing commas in arrays (once you changed it to short syntax).

What do you think? BTW. Why you think phpcs checks should be separate PR?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

samsonasik · 2016-06-25T12:13:22Z

@webimpress my children finally sleeping, I've finally have a chance to add php-cs check and checks for lowest, locked, latest in .travis.yml ;)

samsonasik · 2016-06-25T12:31:32Z

@webimpress travis now green with php-cs check and lowest, locked, and latest check dependencies included \m/

/cc @Ocramius @weierophinney

michalbundyra · 2016-06-25T21:18:26Z

@samsonasik very nice 😄 thanks! I think "locked" is not working properly because we don't have composer.lock in the library. Could you add it, please? (Please remove it from .gitignore). Thanks!

samsonasik · 2016-06-25T21:34:24Z

@webimpress done ;)

samsonasik · 2016-06-25T21:49:02Z

@webimpress add composer.lock make travis failure, suggestion ? or could you make a patch to my branch ?

samsonasik · 2016-06-25T22:16:43Z

@webimpress nvm, travis has been fixed now and green ;) 💃 💃 💃

michalbundyra · 2016-06-26T00:23:35Z

@samsonasik I'm not sure about this phpcs configuration and used package. Is it PSR-2?
I just had a look on one recently released zfcampus package:
https://github.com/zfcampus/zf-development-mode/blob/master/composer.json#L24
and its configuration:
https://github.com/zfcampus/zf-development-mode/blob/master/phpcs.xml

The same library (squizlabs/php_codesniffer) is also used in some zf libraries, for example:
https://github.com/zendframework/zend-code/blob/master/composer.json#L23
and its configuration:
https://github.com/zendframework/zend-code/blob/master/phpcs.xml.dist

Please notice also nice scripts section in composer.json file:
https://github.com/zfcampus/zf-development-mode/blob/master/composer.json#L38-L48

I've also checked zend-mvc library and there we have fabpot/php-cs-fixer with scripts configuration:
https://github.com/zendframework/zend-mvc/blob/master/composer.json#L54-L64

In some library I saw also friendsofphp/php-cs-fixer... I don't know what we should use. There is completely no consistency between zf libraries. It would be nice to have the same rules, checks and used libraries in all zf modules and the same scripts section in composer.json as well.

BTW. Do we still need PHP 5.5 support in the library? ZF3 is gonna support PHP 5.6 and PHP 7.0.
Can we also add tests on hhvm (with allow failures), as it is in other libraries? I wonder when .travis.yml will be updated to run tests also on PHP 7.1 alpha ;)

michalbundyra · 2016-06-26T00:28:18Z

It will be very nice to add this library also to new Zend Skeleton Application (using zend-skeleton-installer). Not sure if it will be possible to auto copy the configuration file?
Of course, this library have to be released first :)

samsonasik · 2016-06-26T11:22:25Z

I think phpcs more enhancement should be separate PR, it's already too far :)

For php 5.5, yes, we need support as we will still uses in zend-mvc 2. This PR used to support both zf-mvc 2 and zf-mvc 3.

Warm regards,

Abdul Malik Ikhsan

Pada 26 Jun 2016, pukul 07.28, webimpress [email protected] menulis:

It will be very nice to add this library also to new Zend Skeleton Application (using zend-skeleton-installer). Not sure if it will be possible to auto copy the configuration file?
Of course, this library have to be released first :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

svycka · 2016-06-27T12:01:31Z

src/Listener/EventLoggingListenerAggregate.php

@@ -22,10 +21,10 @@
 * @author Mark Garrett <[email protected]>
 * @since 0.0.3
 */
-class EventLoggingListenerAggregate implements SharedListenerAggregateInterface


possible BC break?

it tested with EventManager v2 and v3

@svycka Essentially, that interface goes away with v3, so to make code forwards compatible, you cannot directly implement the interface. Since this particular class implements a method for attaching listeners to the shared manager, and that method is what is called inside the Module class, it continues to work perfectly.

weierophinney · 2016-06-27T17:02:37Z

If I do a new minor or major release of this, we can bump to 5.6 support. 😄

Thanks a TON for the work on this @samsonasik , and for the constant, constructive feedback, @webimpress !

weierophinney · 2016-06-27T19:08:41Z

Oh, goodness. Evidently we did a release candidate in October, but never a stable release following.

I'm going to tag that as 1.0.0, and then this will become 1.1.0.

ZF3

weierophinney · 2016-06-27T20:44:03Z

I just discovered one fairly big issue: zend-version is deprecated, and we are no longer updating it for any but LTS releases. I'll see if I can remove that from the toolbar.

Close #214 Close #213 Close #210

Alex Oleshkevich and others added 10 commits April 27, 2016 19:33

Update ZDT for use with modern ZF components

2089b51

use PSR4 autoloader

07fc76c

Merge branch 'master' of github.com:alex-oleshkevich/ZendDeveloperTools

69cc60c

Merge branch 'master' of github.com:alex-oleshkevich/ZendDeveloperTools

dd79364

Merge branch 'master' of github.com:alex-oleshkevich/ZendDeveloperTools

a41ee4c

Remove phpunit.xml

183d6e8

remove 5.3 and 5.4 versions of php from travis

f2dc619

Update composer.json

bf4d652

remove Module::getAutoloaderConfig() as zendframework#210 (comment)

e063b7d

update zend-mvc dependency

9aaca7d

samsonasik mentioned this pull request Jun 24, 2016

Adapt code for use with modern EM. #210

Closed

michalbundyra reviewed Jun 24, 2016
View reviewed changes

samsonasik added 7 commits June 25, 2016 13:20

short array syntax

3125403

another short array syntax

cb1b467

remove php 7 from allow_failures

6f272e5

uses "test" instead of "tests" folder for consistency

616ba68

psr-4 autoloader

50cf2f2

use phpunit: ~4 || ~5

c47b1db

update include module.config.php path

a2554cf

michalbundyra reviewed Jun 25, 2016
View reviewed changes

.travis.yml

matrix:

allow_failures:

- php: 7.0

- ./vendor/bin/phpunit

Copy link

Member

michalbundyra Jun 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one empty line at the and of the file plz

michalbundyra reviewed Jun 25, 2016
View reviewed changes

src/Listener/ToolbarListener.php

}

Copy link

Member

michalbundyra Jun 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove white characters please

samsonasik added 3 commits June 25, 2016 13:47

use ZendDeveloperToolsTest for test

75f6fb7

one empty line at the end of .travis.yml

498cb0d

remove whitespace in ToolbarListener

891d3e8

samsonasik added 2 commits June 25, 2016 19:05

added php-cs check and checks for lowest, locked, latest in .travis.yml

219eb58

cs fix

ca71be4

whitespace fix

0419000

commit composer.lock

f554d92

remove DEPS=locked from php 5.5

3232f51

re-update composer.lock

fdaaf23

samsonasik mentioned this pull request Jun 25, 2016

ZendDeveloperTools is not installable with new skeleton application #212

Closed

svycka reviewed Jun 27, 2016
View reviewed changes

weierophinney added this to the 1.1.0 milestone Jun 27, 2016

weierophinney self-assigned this Jun 27, 2016

weierophinney added a commit to weierophinney/zend-developer-tools that referenced this pull request Jun 27, 2016

Merge pull request zendframework#213 from samsonasik/zf3

50e3bc3

ZF3

weierophinney mentioned this pull request Jun 27, 2016

Follow-up to #213 #214

Merged

weierophinney merged commit fdaaf23 into zendframework:master Jun 27, 2016

weierophinney added a commit that referenced this pull request Jun 27, 2016

Merge branch 'feature/213'

4af0fef

Close #214 Close #213 Close #210

samsonasik deleted the zf3 branch June 27, 2016 21:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ZF3 #213

ZF3 #213

samsonasik commented Jun 24, 2016

michalbundyra Jun 24, 2016

michalbundyra commented Jun 24, 2016 •

edited

Loading

michalbundyra Jun 25, 2016

samsonasik commented Jun 25, 2016

michalbundyra Jun 25, 2016

samsonasik commented Jun 25, 2016

samsonasik commented Jun 25, 2016

michalbundyra commented Jun 25, 2016 •

edited

Loading

samsonasik commented Jun 25, 2016

samsonasik commented Jun 25, 2016

samsonasik commented Jun 25, 2016

michalbundyra commented Jun 25, 2016

samsonasik commented Jun 25, 2016

samsonasik commented Jun 25, 2016

samsonasik commented Jun 25, 2016

michalbundyra commented Jun 26, 2016

michalbundyra commented Jun 26, 2016

samsonasik commented Jun 26, 2016

svycka Jun 27, 2016

samsonasik Jun 27, 2016

weierophinney Jun 27, 2016

weierophinney commented Jun 27, 2016

weierophinney commented Jun 27, 2016

weierophinney commented Jun 27, 2016

ZF3 #213

ZF3 #213

Conversation

samsonasik commented Jun 24, 2016

michalbundyra Jun 24, 2016

Choose a reason for hiding this comment

michalbundyra commented Jun 24, 2016 • edited Loading

michalbundyra Jun 25, 2016

Choose a reason for hiding this comment

samsonasik commented Jun 25, 2016

michalbundyra Jun 25, 2016

Choose a reason for hiding this comment

samsonasik commented Jun 25, 2016

samsonasik commented Jun 25, 2016

michalbundyra commented Jun 25, 2016 • edited Loading

samsonasik commented Jun 25, 2016

samsonasik commented Jun 25, 2016

samsonasik commented Jun 25, 2016

michalbundyra commented Jun 25, 2016

samsonasik commented Jun 25, 2016

samsonasik commented Jun 25, 2016

samsonasik commented Jun 25, 2016

michalbundyra commented Jun 26, 2016

michalbundyra commented Jun 26, 2016

samsonasik commented Jun 26, 2016

svycka Jun 27, 2016

Choose a reason for hiding this comment

samsonasik Jun 27, 2016

Choose a reason for hiding this comment

weierophinney Jun 27, 2016

Choose a reason for hiding this comment

weierophinney commented Jun 27, 2016

weierophinney commented Jun 27, 2016

weierophinney commented Jun 27, 2016

michalbundyra commented Jun 24, 2016 •

edited

Loading

michalbundyra commented Jun 25, 2016 •

edited

Loading