This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 130
implements #219: Show all routing parameters #220
Merged
weierophinney
merged 4 commits into
zendframework:master
from
samsonasik:all-route-parameters
Sep 8, 2016
Merged
implements #219: Show all routing parameters #220
weierophinney
merged 4 commits into
zendframework:master
from
samsonasik:all-route-parameters
Sep 8, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #219 |
'controller' => ($match === null) ? 'N/A' : $match->getParam('controller', 'N/A') | ||
'controller' => ($match === null) ? 'N/A' : $match->getParam('controller', 'N/A'), | ||
'other_route_parameters' => ($match === null) ? 'N/A' : array_filter($match->getParams(), function ($key) { | ||
return $key !== 'action' && $key !== 'controller'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage of in_array
should improve readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implemented.
weierophinney
added a commit
that referenced
this pull request
Sep 8, 2016
implements #219: Show all routing parameters
weierophinney
added a commit
that referenced
this pull request
Sep 8, 2016
Thanks, @samsonasik |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RalfEggert here we go. also fixes the zdt-toolbar-info-redundant class that only show last record.