Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change nRF5340DK board files to handle CPUNET pin configuration with DTS nodes #37798

Closed
crfosse opened this issue Aug 19, 2021 · 1 comment
Closed
Labels
Enhancement Changes/Updates/Additions to existing features

Comments

@crfosse
Copy link

crfosse commented Aug 19, 2021

Is your enhancement proposal related to a problem? Please describe.
Currently pins P1.0, P1.1, P0.10 and P0.11 are hard coded for UARTE use in nrf5340_cpunet_reset.c. The fact that these pins are unavailable when a nRF5340 application is configured to use both cores (for example when CONFIG_BT=y) is not communicated at all to the user. Any configuration of these pins in DTS or in the application will silently be ignored. For example, any GPIO interrupts tied to these pins won't work.

Describe the solution you'd like
This is already explained in nrf5340_cpunet_reset.c with the following comment: /* This should come from DTS, possibly an overlay. */. Board configuration with DTS has already been implemented for the nRF9160DK and a similar approach can likely be used for the nRF5340DK.

Describe alternatives you've considered
You can easily work around this by using different pins, but the fact that the mentioned pins are unavailable should be communicated to the user through documentation and build warnings.

Additional context
I've tested this myself on an nRF5340DK with the /samples/basic/button sample.

@crfosse crfosse added the Enhancement Changes/Updates/Additions to existing features label Aug 19, 2021
@anangl
Copy link
Member

anangl commented Mar 2, 2022

Addressed in #43047.

@anangl anangl closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

No branches or pull requests

2 participants