Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: peci: user space handlers not building correctly #45222

Closed
albertofloyd opened this issue Apr 28, 2022 · 1 comment · Fixed by #51415
Closed

drivers: peci: user space handlers not building correctly #45222

albertofloyd opened this issue Apr 28, 2022 · 1 comment · Fixed by #51415
Assignees
Labels
area: PECI Platform Environment Control Interface bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@albertofloyd
Copy link
Collaborator

albertofloyd commented Apr 28, 2022

Describe the bug
PECI subsystem cannot be enabled with USERSPACE feature
User handlers do not build correctly.

Please also mention any information which could help others to understand
the problem you're facing:

  • What target platform are you using?
  • What have you tried to diagnose or workaround this issue?
  • ...

To Reproduce
Steps to reproduce the behavior:

  1. cd samples/drivers/peci
  2. west build -b mec172xevb_assy6906 -- -DCONFIG_ARM_MPU=y -DCONFIG_USERSPACE=y
  3. See build error

Expected behavior
PECI handlers build correctly

Impact
High

Logs and console output
/home/jamezaar/ecwork/zephyr_fork/drivers/peci/peci_handlers.c:14:9: error: implicit declaration of function 'Z_SYSCALL_DRIVER_PECI'; did you mean 'Z_SYSCALL_DRIVER_GEN'? [-Werror=implicit-function-declaration]
14 | Z_OOPS(Z_SYSCALL_DRIVER_PECI(dev, config));
| ^~~~~~~~~~~~~~~~~~~~~
/home/jamezaar/ecwork/zephyr_fork/include/syscall_handler.h:293:7: note: in definition of macro 'Z_OOPS'
293 | if (expr) {
| ^~~~
/home/jamezaar/ecwork/zephyr_fork/drivers/peci/peci_handlers.c:14:36: error: 'config' undeclared (first use in this function); did you mean 'mpu_config'?
14 | Z_OOPS(Z_SYSCALL_DRIVER_PECI(dev, config));
| ^~~~~~
/home/jamezaar/ecwork/zephyr_fork/include/syscall_handler.h:293:7: note: in definition of macro 'Z_OOPS'
293 | if (expr) {
| ^~~~
/home/jamezaar/ecwork/zephyr_fork/drivers/peci/peci_handlers.c:14:36: note: each undeclared identifier is reported only once for each function it appears in
14 | Z_OOPS(Z_SYSCALL_DRIVER_PECI(dev, config));
| ^~~~~~
/home/jamezaar/ecwork/zephyr_fork/include/syscall_handler.h:293:7: note: in definition of macro 'Z_OOPS'
293 | if (expr) {
| ^~~~
/home/jamezaar/ecwork/zephyr_fork/drivers/peci/peci_handlers.c: In function 'z_vrfy_peci_enable':
/home/jamezaar/ecwork/zephyr_fork/drivers/peci/peci_handlers.c:22:36: error: 'enable' undeclared (first use in this function)
22 | Z_OOPS(Z_SYSCALL_DRIVER_PECI(dev, enable));
| ^~~~~~
/home/jamezaar/ecwork/zephyr_fork/include/syscall_handler.h:293:7: note: in definition of macro 'Z_OOPS'
293 | if (expr) {
| ^~~~
/home/jamezaar/ecwork/zephyr_fork/drivers/peci/peci_handlers.c: In function 'z_vrfy_peci_disable':
/home/jamezaar/ecwork/zephyr_fork/drivers/peci/peci_handlers.c:30:36: error: 'disable' undeclared (first use in this function)
30 | Z_OOPS(Z_SYSCALL_DRIVER_PECI(dev, disable));
| ^~~~~~~
/home/jamezaar/ecwork/zephyr_fork/include/syscall_handler.h:293:7: note: in definition of macro 'Z_OOPS'
293 | if (expr) {
| ^~~~
/home/jamezaar/ecwork/zephyr_fork/drivers/peci/peci_handlers.c: In function 'z_vrfy_peci_transfer':
/home/jamezaar/ecwork/zephyr_fork/drivers/peci/peci_handlers.c:41:36: error: 'transfer' undeclared (first use in this function)
41 | Z_OOPS(Z_SYSCALL_DRIVER_PECI(dev, transfer));
| ^~~~~~~~
/home/jamezaar/ecwork/zephyr_fork/include/syscall_handler.h:293:7: note: in definition of macro 'Z_OOPS'
293 | if (expr) { \

Environment (please complete the following information):

  • OS: (e.g. Linux, MacOS, Windows)
  • Toolchain (e.g Zephyr SDK, ...)
  • Commit SHA or Version used

Additional context
Add any other context that could be relevant to your issue, such as pin setting,
target configuration, ...

@albertofloyd albertofloyd added the bug The issue is a bug, or the PR is fixing a bug label Apr 28, 2022
@henrikbrixandersen henrikbrixandersen added the area: PECI Platform Environment Control Interface label May 3, 2022
@mbolivar-nordic mbolivar-nordic added the priority: low Low impact/importance bug label May 3, 2022
@mbolivar-nordic mbolivar-nordic added priority: medium Medium impact/importance bug and removed priority: low Low impact/importance bug labels May 3, 2022
@github-actions
Copy link

github-actions bot commented Jul 3, 2022

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: PECI Platform Environment Control Interface bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants