Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET_TCP_BACKLOG_SIZE is unused, it has to be either implemented or deleted #45324

Closed
AndreyDodonov-EH opened this issue May 4, 2022 Discussed in #44973 · 6 comments · Fixed by #45614
Closed

NET_TCP_BACKLOG_SIZE is unused, it has to be either implemented or deleted #45324

AndreyDodonov-EH opened this issue May 4, 2022 Discussed in #44973 · 6 comments · Fixed by #45614
Assignees
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@AndreyDodonov-EH
Copy link
Contributor

Discussed in #44973

Originally posted by AndreyDodonov-EH April 20, 2022
According to the quick grep, it's not used anymore, but still present in KConfig:
https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/net/ip/Kconfig#L366

Is it not needed anymore or am I missing something?

@mbolivar-nordic mbolivar-nordic added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels May 10, 2022
@mbolivar-nordic
Copy link
Contributor

@AndreyDodonov-EH could you please send a PR removing the unused option as suggested by @jukkar ?

@AndreyDodonov-EH
Copy link
Contributor Author

@mbolivar-nordic Yeah, will do!
But we need to keep this (or similar) issue open to make sure that we know that there is implementation missing.

@AndreyDodonov-EH
Copy link
Contributor Author

@mbolivar-nordic Here you go: #45614

@mbolivar-nordic
Copy link
Contributor

But we need to keep this (or similar) issue open to make sure that we know that there is implementation missing.

OK, please open a new issue and mark it as an "enhancement" describing the missing implementation

@AndreyDodonov-EH
Copy link
Contributor Author

@mbolivar-nordic
I think I was incorrect, I spent some time trying to understand the current implementation, and now I think that this functionality is not missing, because we can have multiple contexts (i.e. sockets) independent of each other, so the number of simultaneous connection attempts can be arbitrary.

@rlubos Can you confirm that this is indeed so and it's not necessary to open a new issue?

As reference:
https://docs.zephyrproject.org/3.0.0/reference/kconfig/CONFIG_NET_TCP_BACKLOG_SIZE.html

@rlubos
Copy link
Contributor

rlubos commented May 16, 2022

@mbolivar-nordic I think I was incorrect, I spent some time trying to understand the current implementation, and now I think that this functionality is not missing, because we can have multiple contexts (i.e. sockets) independent of each other, so the number of simultaneous connection attempts can be arbitrary.

@rlubos Can you confirm that this is indeed so and it's not necessary to open a new issue?

As reference: https://docs.zephyrproject.org/3.0.0/reference/kconfig/CONFIG_NET_TCP_BACKLOG_SIZE.html

I think you're right, we allocate a new TCP context for each initiated connection so that config is no longer applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants