Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: Controller: df: CTE request not disabled if run in single shot mode #45725

Closed
ppryga-nordic opened this issue May 17, 2022 · 0 comments · Fixed by #45726
Closed

Bluetooth: Controller: df: CTE request not disabled if run in single shot mode #45725

ppryga-nordic opened this issue May 17, 2022 · 0 comments · Fixed by #45726
Assignees
Labels
area: Bluetooth Controller area: Bluetooth LLCP area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@ppryga-nordic
Copy link
Collaborator

Describe the bug
There is an error. CTE request control procedure can be run in single
shot or periodic mode. In case of run in single show, it is not disabled after completion.

The code responsible for the disable was deleted in commit: ac7d050.

To Reproduce
Steps to reproduce the behavior:

  1. Build direction_finding_central sample.
  2. Change
const struct bt_df_conn_cte_req_params cte_req_params = {
	.interval = CTE_REQ_INTERVAL,

to

const struct bt_df_conn_cte_req_params cte_req_params = {
	.interval = 0,
  1. Add call to enable_cte_reqest in cte_recv_cb.
  2. Observe console output. Second call to enable_cte_req will fail with error code.

Expected behavior
The second call to ebq_cte_req should be successful.

Impact
Prevents conformance tests to pass.
Use of single shot CTE request in production projects is not possible.

@ppryga-nordic ppryga-nordic changed the title Bluetooth: Controller: df: CTE req not disabled if run in single shot Bluetooth: Controller: df: CTE request not disabled if run in single shot mode May 17, 2022
@carlescufi carlescufi added the priority: low Low impact/importance bug label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Controller area: Bluetooth LLCP area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants