sysbuild: shared cache variable instead of local scope variable #52884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: zephyrproject-rtos#52353 If a CMake variable is available in both local scope and as CMake cache variable, then the use of `${<var>}` fetches the local scoped variable. If only the cache variable is set, then things works as expected. Ensure that the cached variable is always the variable being shared to images by using `$CACHE{<var>}` instead. Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand
force-pushed
the
sysbuild/cache_var_sharing
branch
from
cf07e56
to
2f5feec
Compare
nordicjm
previously approved these changes
Dec 8, 2022
tejlmand
force-pushed
the
sysbuild/cache_var_sharing
branch
from
2f5feec
to
a8df2d4
Compare
tejlmand
requested review from
dcpleung,
andyross,
rlubos,
tbursztyka,
pfalcon,
carlescufi,
de-nordic,
carlocaione,
alwa-nordic,
jhedberg,
Vudentz,
sjanc,
cvinayak,
thoh-ot,
kruithofa,
mbolivar-nordic,
microbuilder and
ceolin
as code owners
tejlmand
removed request for
jhedberg,
tbursztyka,
pgielda,
Vudentz,
kgugala,
cvinayak,
sjanc,
stephanosio,
carlescufi,
anangl,
rlubos,
aescolar,
thoh-ot,
dcpleung,
alwa-nordic,
daor-oti,
de-nordic,
kruithofa,
mbolivar-nordic,
MaureenHelm,
galak and
ioannisg
|
@Cherish-Gww FYI |
mbolivar-nordic
approved these changes
Dec 9, 2022
carlescufi
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #52353
If a CMake variable is available in both local scope and as CMake cache variable, then the use of
${<var>}fetches the local scoped variable. If only the cache variable is set, then things works as expected.Ensure that the cached variable is always the variable being shared to images by using
$CACHE{<var>}instead.Signed-off-by: Torsten Rasmussen [email protected]