Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: stepper: refactor common registers to tmc5xxx #81484

Merged
merged 2 commits into from
Nov 19, 2024
Merged

drivers: stepper: refactor common registers to tmc5xxx #81484

merged 2 commits into from
Nov 19, 2024

Conversation

jilaypandya
Copy link
Contributor

@jilaypandya jilaypandya commented Nov 17, 2024 •
edited
Loading

This PR refactors common register values to tmc5xxx.
This PR facilitates #80784 .

@jilaypandya
drivers: stepper: tmc5xxx: generalized macros for tmc5xxx
f0c3274 
This commit generalizes macros which are common to tmc5xxx drivers

Signed-off-by: Jilay Pandya <[email protected]>
@jilaypandya
drivers: stepper: tmc5041: use tmc5xxx generalized macros
dba952e 
This commit refactors tmc5041 driver to use tmc5xxx generalized macros

Signed-off-by: Jilay Pandya <[email protected]>
@fabiobaltieri fabiobaltieri added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Nov 18, 2024
bjarki-andreasen
bjarki-andreasen approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred this being one commit, since seemingly the first commit is incompatible with the driver, which is then adapted in the second commit :)

@nashif nashif merged commit 6098b2f into zephyrproject-rtos:main Nov 19, 2024
25 checks passed
@jilaypandya jilaypandya deleted the feature/tmc5xxx-common-macros branch November 19, 2024 15:23
@jilaypandya
Copy link
Contributor Author

I would have preferred this being one commit, since seemingly the first commit is incompatible with the driver, which is then adapted in the second commit :)

That's correct. Thanks for pointing it out. I'll keep this in mind next time :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjarki-andreasen bjarki-andreasen bjarki-andreasen approved these changes

@dipakgmx dipakgmx dipakgmx approved these changes

@faxe1008 faxe1008 faxe1008 approved these changes

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@kartben kartben kartben approved these changes

Assignees

@jilaypandya jilaypandya

Labels
area: Stepper Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jilaypandya @kartben @fabiobaltieri @faxe1008 @dipakgmx @bjarki-andreasen @nashif @zephyrbot