Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation issue on Windows with ninja #2579

Closed
diorcety opened this issue May 17, 2017 · 10 comments
Closed

Compilation issue on Windows with ninja #2579

diorcety opened this issue May 17, 2017 · 10 comments

Comments

@diorcety
Copy link

On windows with ninja the precompiled.hpp can't be found. Put precompiled.cpp first doesn't solve the issue, a better dependency tree must be done.

Cf diorcety@66b94c7

@bluca
Copy link
Member

bluca commented May 17, 2017

I don't think we support ninja?

@bluca
Copy link
Member

bluca commented May 17, 2017

But it's windows stuff so I'm not really sure

@diorcety
Copy link
Author

Ninja is not only for windows. But in this case, the issue appear because ninja doesn't process source in the given order. My fix force a dependency which force at the end the order

@bjovke
Copy link
Contributor

bjovke commented May 18, 2017

@diorcety What is ninja?

@diorcety
Copy link
Author

https://ninja-build.org/

@bluca
Copy link
Member

bluca commented May 18, 2017

As I mentioned there's no support for it and afaik you're the first to ask, so if you are interested please do send PRs to add support for it

@bjovke
Copy link
Contributor

bjovke commented May 18, 2017

@diorcety Thanks. I don't think building with ninja is supported for libzmq.

@diorcety
Copy link
Author

Okay this is the only fix to do for supporting ninja :)

@bluca
Copy link
Member

bluca commented May 18, 2017

Could you please send a PR for it?

@bluca
Copy link
Member

bluca commented May 18, 2017

Fixed by #2580

@bluca bluca closed this as completed May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants